New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): pull hotfix-release/v1.44.1 into main #2689

Merged

sandeepdsvs merged 2 commits into main from hotfix-release/v1.44.1

Oct 6, 2023

Contributor

devops-github-rudderstack commented Oct 6, 2023

👑 An automated PR

anantjain45823 and others added 2 commits

October 5, 2023 12:48


          fix: criteo_aud auth_token expire code incorporated (#2687)

cbe333a

* fix: criteo_aud auth_token expire code incorporated

* test cases added


          chore(release): 1.44.1

13473a0

devops-github-rudderstack requested review from a team and sivashanmukh as code owners

October 6, 2023 08:18

devops-github-rudderstack requested review from aashishmalik and shrouti1507

October 6, 2023 08:18

anantjain45823 approved these changes

View reviewed changes

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6fc3d97) 87.01% compared to head (13473a0) 87.02%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2689   +/-   ##
=======================================
  Coverage   87.01%   87.02%           
=======================================
  Files         635      635           
  Lines       28311    28314    +3     
  Branches     6720     6723    +3     
=======================================
+ Hits        24636    24639    +3     
  Misses       3341     3341           
  Partials      334      334

Files	Coverage Δ
.../v0/destinations/criteo_audience/networkHandler.js	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sandeepdsvs approved these changes

View reviewed changes

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

89.5% Coverage
0.0% Duplication

krishna2020 approved these changes

View reviewed changes

utsabc approved these changes

View reviewed changes

sandeepdsvs merged commit 5e762fc into main

devops-github-rudderstack deleted the hotfix-release/v1.44.1 branch

October 6, 2023 08:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sandeepdsvs sandeepdsvs approved these changes

anantjain45823 anantjain45823 approved these changes

utsabc utsabc approved these changes

krishna2020 krishna2020 approved these changes

sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

aashishmalik Awaiting requested review from aashishmalik aashishmalik is a code owner automatically assigned from rudderlabs/integrations

shrouti1507 Awaiting requested review from shrouti1507 shrouti1507 is a code owner automatically assigned from rudderlabs/integrations

Labels

None yet